Hackfix for calling SelectAll with SelectedItem binding #13868
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
As described in #13676, calling
SelectAll()
on aListBox
with no current selection and a two-waySelectedIndex
orSelectedItem
binding in place, causesSelectAll()
to fail. What was happening is:SelectAll()
is calledSelectedIndex
/SelectedItem
property on theSelectionModel
PropertyChanged
to be raised forSelectedIndex
/SelectedItem
on theListBox
SelectedIndex
/SelectedItem
, even though this value hasn't changedSelectedIndex
/SelectedItem
's semantics are such that setting them clears all other selected itemsStep 6 is a bug in the binding system: we should not be writing an unchanged value back to the target due to a change in the source, and this will be fixed in the upcoming binding system refactor. However in the meantime, I think we need a hackfix as an interim solution. The easiest way to do this is to add the fix to
SelectionModel
.Fixed issues
Fixes #13676