Fix for crash in issue 13822 #13869
Merged
Fix for crash in issue 13822 #13869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
added
the
backport-candidate-11.0.x
maxkatz6
approved these changes
Dec 7, 2023
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
maxkatz6
added a commit
that referenced
this pull request
Jan 17, 2024
Co-authored-by: michael.david.howard@outlook.com <michael.david.howard@outlook.com> Co-authored-by: Max Katz <maxkatz6@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This fixes a crash in issue 13822 when remote terminal services are involved.
What is the current behavior?
The incorrect behaviour is repeated exceptions being thrown when the presentation call returns an occluded status-code indicating that nothing was actually done.
The default Microcom behaviour of interpreting a non-zero code as a catastrophic failure was not appropriate for present. The IDL file has been modified to use an Int32 instead.
What is the updated/expected behavior with this PR?
Present calls no longer throw exceptions when the desktop is occluded via a remote terminal services connection going into standby or the screen locking.
The crash I could only get to replicate when the debugger was attached, which was curious.
With the fix in place I was able to seamlessly transition from remote desktop to remote-desktop-locked to remote-desktop-idle-disconnected to a physical session and all the way back again without any disruptions.
How was the solution implemented (if it's not obvious)?
The IDL file was modified to return a plain Int32 rather than a HRESULT
Checklist
Breaking changes
Not aware of any.
Obsoletions / Deprecations
Not applicable
Fixed issues
#13822