Fix ToggleSwitch dragging #13893
Merged
Fix ToggleSwitch dragging #13893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
jmacato
approved these changes
Dec 10, 2023
jmacato
added
the
backport-candidate-11.0.x
|
cc for backport to stable @maxkatz6 |
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
maxkatz6
pushed a commit
that referenced
this pull request
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fixes dragging the "knob" of a
ToggleSwitchto set its stateWhat is the current behavior?
When the mouse button is released after dragging, the
ToggleSwitch's state is set to the opposite of what it should be set to. This is a regression, which appears to have occurred sometime in 11.xWhat is the updated/expected behavior with this PR?
Dragging the "knob" of a
ToggleSwitchnow correctly sets its stateHow was the solution implemented (if it's not obvious)?
It's a two-line fix, lol