Fix Windows 7 'api-ms-win-core-winrt-string-l1-1-0.dll' error #14436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
|
Alternatively, we could make this a one-line PR by checking for the Windows version here. Although the behavior would be more implicit, I prefer doing the checks in the methods. |
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Feb 1, 2024
|
Thank you! Current changes look good for me. Changing HString code would be more invasive, as it would affect WinRT Compositor code, which doesn't need additional version checks. |
maxkatz6
added
bug
os-windows
backport-candidate-11.0.x
|
Just fyi @david-szabo97 if you add the keyword fixes #xxxx then the issue will close automatically. Thanks for your contribution 🙏 |
maxkatz6
pushed a commit
that referenced
this pull request
Feb 8, 2024
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Add a check before creating any HStringInterop in the WinRTApiInformation class.
What is the current behavior?
HStringInterop class is instantiated even when WinRTMethods is not available on the current Windows version.
What is the updated/expected behavior with this PR?
HStringInterop class won't be instantiated, therefore it won't try to load 'api-ms-win-core-winrt-string-l1-1-0.dll' which causes crash on Windows 7.
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
#14309