[macOS] Introduce native TopLevelImpl #15800
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gillibald
changed the title
Gillibald
changed the title
|
You can test this PR using the following package version. |
kekekeks
reviewed
May 24, 2024
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Jun 5, 2024
3 tasks
|
Superseded by: #15932 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR introduces a TopLevelImpl for the Avalonia.Native backend. The WindowBaseImpl previously implemented this layer.
This makes it possible to have more embedding solutions that only require an NSView.
Ime interaction with Popups is also fixed. Only the Popup's parent window is the key window so that is responding to key events but Avalonia isn't using the parent's text input method. Hence, we must pretend the Popup's input method is the parent's.
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues