integrate groupbox control

[mameolan]

What does the pull request do?

adds the missing GroupBox Control

Checklist

• Added unit tests (if possible)?
• Added XML documentation to any related classes?
• Consider submitting a PR to https://github.com/AvaloniaUI/Avaloniaui.net with user documentation

[dnfclas]

All CLA requirements met.

[danwalmsley]

Very good, just 1 potential issue found

[danwalmsley]

1 last minor change

[danwalmsley]

@mameolan sorry about this, but any change we can have it styled like the wpf one?

[JamRemco]

@mameolan sorry about this, but any change we can have it styled like the wpf one?

Seiously that's so win95 haha ;)

[Gillibald]

I personally dislike this control because it brings no functionality. It is just a styled HeaderedContentControl

[grokys]

For reference, this control currently looks like this:

can we have it styled like the wpf one?

I don't think this would be a good idea, the WPF one is Win9x styled and we use a more UWP-style. Thing is, the GroupBox doesn't really have a more modern style, it's a control that doesn't really exist any more. Can anyone show me an example of a GroupBox in a modern application?

I personally dislike this control because it brings no functionality. It is just a styled HeaderedContentControl

Yeah, for this reason and the styling/outdatedness issues, I'm not sure we would want to accept this control into Avalonia core.

[danwalmsley]

@grokys the argument for having it could be a lot of wpf legacy code might have it, and it just makes it easier when copying and pasting examples... i remember now this is the second time someone has sent a PR for this...

im neutral on having it though.

[kekekeks]

Could we have a proper template for HeaderedContentControl and keep GroupBox as a deprecated alias?

[JamRemco]

@grokys
I got you point, its like template a textblock and call it a new control. however we could make a Styleclass for HeaderContentControl thats kinda looks and act like a groupbox.
So instead of a new control you just got a style
xaml <HeaderedContentControl classes = "Groupnox"/>
That way Everybody's happy.

@danwalmsley agreed people seems to like/use it .

@kekekeks how would a "proper" template looks/function in your oppinion.

[kekekeks]

@JamRemco Right now HeaderedContentControl has no template at all.

[danwalmsley]

will close for now... @mameolan sorry... hope you will continue to contribute :)

[CorruptComputer]

I actually am a fan of how these look, especially when making small UI's to command line apps. Is there no chance that this could get added still? I don't seem the harm with it, since if you don't like it you can just not use it.

[rstm-sf]

You can create a separate control, the source code is available ;)

Also it looks like it is available in this project https://github.com/mameolan/Avalonia.ExtendedToolkit