Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ControlCatalog.Android: Added splash screen #5328

Merged
merged 3 commits into from
Jan 21, 2021

Conversation

jp2masa
Copy link
Contributor

@jp2masa jp2masa commented Jan 21, 2021

What does the pull request do?

  • ControlCatalog.Android:
    • Added splash screen.
    • Removed unused resources.

What is the current behavior?

The app starts with a black screen while loading, which takes a while, it doesn't look nice.

What is the updated/expected behavior with this PR?

A splash screen is shown when the app starts, there's still a black screen for some seconds after the splash screen disappears, but it's much better like this I believe. Also shows future Avalonia on Android users how to add a splash screen which they will probably want to do as the loading will always take at least a few seconds.

Checklist

Removed unused resources.
Copy link
Member

@danwalmsley danwalmsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danwalmsley danwalmsley merged commit 091dc64 into AvaloniaUI:master Jan 21, 2021
@jp2masa jp2masa deleted the android branch January 21, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants