Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api to allow loading WriteableBitmap from File / Stream #5800

Merged
merged 15 commits into from
May 17, 2021

Conversation

danwalmsley
Copy link
Member

What does the pull request do?

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Fixed issues

@danwalmsley danwalmsley changed the title Api to allow loading WriteableBitmap from File / Stream WIP: Api to allow loading WriteableBitmap from File / Stream Apr 19, 2021
Copy link

@Szpoti Szpoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, its a usefull feature to have.
One thing I dont quite understand is why are there a bunch of functions with
throw new NotImplementedException(); inside? Will these be changed or they have some other purpose?

@danwalmsley
Copy link
Member Author

Code looks good, its a usefull feature to have.
One thing I dont quite understand is why are there a bunch of functions with
throw new NotImplementedException(); inside? Will these be changed or they have some other purpose?

Ah these are because they are test stubs, and these methods dont get tested from every test stub (or even at all)

hence notimplemented... but those methods are not part of the actual framework, just the testing part.

…ble-bitmap-from-file

# Conflicts:
#	src/Avalonia.Controls/ApiCompatBaseline.txt
#	src/Avalonia.Visuals/ApiCompatBaseline.txt
@danwalmsley danwalmsley changed the title WIP: Api to allow loading WriteableBitmap from File / Stream Api to allow loading WriteableBitmap from File / Stream May 10, 2021
Copy link
Collaborator

@MarchingCube MarchingCube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly fine but there are a few smaller problems.

src/Avalonia.Visuals/Platform/IPlatformRenderInterface.cs Outdated Show resolved Hide resolved
src/Avalonia.Visuals/Platform/IPlatformRenderInterface.cs Outdated Show resolved Hide resolved
src/Avalonia.Visuals/Platform/IPlatformRenderInterface.cs Outdated Show resolved Hide resolved
src/Avalonia.Visuals/Media/Imaging/WriteableBitmap.cs Outdated Show resolved Hide resolved
src/Skia/Avalonia.Skia/WriteableBitmapImpl.cs Outdated Show resolved Hide resolved
src/Skia/Avalonia.Skia/WriteableBitmapImpl.cs Outdated Show resolved Hide resolved
Copy link
Collaborator

@MarchingCube MarchingCube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Noticed two minor doc issues that I've missed before.

src/Avalonia.Visuals/Media/Imaging/WriteableBitmap.cs Outdated Show resolved Hide resolved
src/Avalonia.Visuals/Media/Imaging/WriteableBitmap.cs Outdated Show resolved Hide resolved
maxkatz6 and others added 3 commits May 16, 2021 23:11
@maxkatz6 maxkatz6 enabled auto-merge May 17, 2021 03:11
@maxkatz6 maxkatz6 merged commit f7a17de into master May 17, 2021
@maxkatz6 maxkatz6 deleted the feature/load-writeable-bitmap-from-file branch May 17, 2021 03:28
danwalmsley pushed a commit that referenced this pull request May 19, 2021
…p-from-file

Api to allow loading WriteableBitmap from File / Stream
# Conflicts:
#	src/Avalonia.Visuals/ApiCompatBaseline.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants