-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api to allow loading WriteableBitmap from File / Stream #5800
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, its a usefull feature to have.
One thing I dont quite understand is why are there a bunch of functions with
throw new NotImplementedException();
inside? Will these be changed or they have some other purpose?
Ah these are because they are test stubs, and these methods dont get tested from every test stub (or even at all) hence notimplemented... but those methods are not part of the actual framework, just the testing part. |
…ble-bitmap-from-file # Conflicts: # src/Avalonia.Controls/ApiCompatBaseline.txt # src/Avalonia.Visuals/ApiCompatBaseline.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly fine but there are a few smaller problems.
…ble-bitmap-from-file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Noticed two minor doc issues that I've missed before.
Co-authored-by: Dariusz Komosiński <darek.komosinski@gmail.com>
Co-authored-by: Dariusz Komosiński <darek.komosinski@gmail.com>
…p-from-file Api to allow loading WriteableBitmap from File / Stream # Conflicts: # src/Avalonia.Visuals/ApiCompatBaseline.txt
What does the pull request do?
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Fixed issues