Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont use datatemplate in datavalidationerrors. #5910

Merged
merged 3 commits into from
May 13, 2021

Conversation

danwalmsley
Copy link
Member

@danwalmsley danwalmsley commented May 12, 2021

What does the pull request do?

remove use of datatemplates in DataValidationErrors.

What is the current behavior?

users cannot provide their own template easily.

What is the updated/expected behavior with this PR?

User can supply a template simply like:

<Application.DataTemplates>
    <local:ViewLocator/>
    <DataTemplate DataType="models:ErrorDescriptor" x:DataType="models:ErrorDescriptor">
      <TextBlock Text="Error here"/>
    </DataTemplate>

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

@danwalmsley danwalmsley changed the title use datatemplates instead of itemstemplate for datavalidationerrors. dont use datatemplate in datavalidationerrors. May 13, 2021
@danwalmsley danwalmsley merged commit dfd18ff into master May 13, 2021
@danwalmsley danwalmsley deleted the fixes-data-validation-errors-use-datatemplates-1 branch May 13, 2021 10:05
danwalmsley added a commit that referenced this pull request May 19, 2021
…-use-datatemplates-1

dont use datatemplate in datavalidationerrors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants