-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/devtools filter text box #5991
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
force-pushed
the
feature/devtools-filter-text-box
branch
from
May 29, 2021 06:36
67599fb
to
9d14b44
Compare
maxkatz6
force-pushed
the
feature/devtools-filter-text-box
branch
from
May 29, 2021 06:36
9d14b44
to
f83d8e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great! This really cleans up filtering part. Would be also useful when we add filtering for visual/logical tree nodes.
src/Avalonia.Diagnostics/Diagnostics/Controls/FilterTextBox.axaml
Outdated
Show resolved
Hide resolved
src/Avalonia.Diagnostics/Diagnostics/ViewModels/FilterViewModel.cs
Outdated
Show resolved
Hide resolved
MarchingCube
approved these changes
May 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
maxkatz6
added a commit
that referenced
this pull request
May 30, 2021
…-box Feature/devtools filter text box
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Improves filter text box in properties, setters and events lists.
What is the current behavior?
What is the updated/expected behavior with this PR?
(note, I changed font size to be smaller after recording this gif)
Notes
I used icons from VSCode - https://github.com/microsoft/vscode-icons (see Legal Notice, it seems to be allowed to use under MIT license)