Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/devtools filter text box #5991

Merged
merged 5 commits into from
May 29, 2021
Merged

Conversation

maxkatz6
Copy link
Member

What does the pull request do?

Improves filter text box in properties, setters and events lists.

What is the current behavior?

image

What is the updated/expected behavior with this PR?

Animation
(note, I changed font size to be smaller after recording this gif)

Notes

I used icons from VSCode - https://github.com/microsoft/vscode-icons (see Legal Notice, it seems to be allowed to use under MIT license)

@maxkatz6 maxkatz6 force-pushed the feature/devtools-filter-text-box branch from 67599fb to 9d14b44 Compare May 29, 2021 06:36
Copy link
Collaborator

@MarchingCube MarchingCube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! This really cleans up filtering part. Would be also useful when we add filtering for visual/logical tree nodes.

Copy link
Collaborator

@MarchingCube MarchingCube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@maxkatz6 maxkatz6 merged commit df892e4 into master May 29, 2021
@maxkatz6 maxkatz6 deleted the feature/devtools-filter-text-box branch May 29, 2021 20:52
maxkatz6 added a commit that referenced this pull request May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants