Optimize shape rendering (pen creation mostly). #5997
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
An optimization for core
Shape
rendering that minimizes perf and memory impact.Best case (no brushes) improved cpu perf x200 and removed all allocations.
Worst case we are looking at cpu perf x38 and 98% memory reduction.
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Best optimization is to just avoid doing any work, so when
Stroke
is not set we can just ignore it.Also majority of rendered shapes are not using dashes so there is no point in allocating dash style for everything.
Biggest change is using immutable pen and dash styles. Mutable variants have an absurd overhead due to change tracking.
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues