Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unescaping parameter types #78

Merged
merged 2 commits into from Oct 26, 2020
Merged

unescaping parameter types #78

merged 2 commits into from Oct 26, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 21, 2020

The main change here is from {{ParameterType}} to {{{ParameterType}}} in nine places.
Other changes are from regenerating the Cdr.Banking sample code.
There is also an addition of a = default to the last set of parameters of a controller method as compulsory parameters can not come after optional parameters.

…n Web API Controller. Add test for fix. Re-gen and revalidate.
@chullybun
Copy link
Collaborator

Pull request accepted.

With the exception of the Web API Controller parameter default. This fix created other issues with the likes of Create and Update where the value was defaulting to = default where the value was not nullable. If a parameter should be defaulted for a controller then the parameter default code-gen configuration should be used; for example: <Parameter Name="Names" Type="List&lt;string&gt;" Default="default" />.

@chullybun chullybun merged commit a10aa10 into Avanade:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant