App Info and App Store Version #116

MortenGregersen · 2020-08-31T20:42:44Z

No description provided.

MortenGregersen · 2020-08-31T21:09:53Z

I don't understand why the build fails. It doesn't look like the build has started on Bitrise.

AvdLee

Thanks, this is great!

SwiftLeeBot · 2020-09-01T07:50:56Z

	Warnings
⚠️	Please provide a summary in the Pull Request description
⚠️	Sources/Models/AppStoreVersion.swift#L60 - Types should be nested at most 1 level deep (`nesting`)
⚠️	Sources/Models/AppStoreVersion.swift#L65 - Types should be nested at most 1 level deep (`nesting`)
⚠️	Sources/Models/AppStoreVersion.swift#L80 - Types should be nested at most 1 level deep (`nesting`)
⚠️	Sources/Models/AppStoreVersion.swift#L90 - Types should be nested at most 1 level deep (`nesting`)
⚠️	Sources/Models/AppStoreVersion.swift#L95 - Types should be nested at most 1 level deep (`nesting`)
⚠️	Sources/Models/AppStoreVersion.swift#L120 - Types should be nested at most 1 level deep (`nesting`)
⚠️	Sources/Models/AppStoreVersion.swift#L125 - Types should be nested at most 1 level deep (`nesting`)
⚠️	Sources/Models/AppStoreVersion.swift#L140 - Types should be nested at most 1 level deep (`nesting`)
⚠️	Sources/Models/AppStoreVersion.swift#L150 - Types should be nested at most 1 level deep (`nesting`)
⚠️	Sources/Models/AppStoreVersion.swift#L155 - Types should be nested at most 1 level deep (`nesting`)
⚠️	Sources/Models/AppStoreVersion.swift#L165 - Types should be nested at most 1 level deep (`nesting`)
⚠️	Sources/Models/AppStoreVersion.swift#L170 - Types should be nested at most 1 level deep (`nesting`)
⚠️	Sources/Models/AppStoreVersion.swift#L180 - Types should be nested at most 1 level deep (`nesting`)
⚠️	Sources/Models/AppStoreVersion.swift#L185 - Types should be nested at most 1 level deep (`nesting`)
⚠️	Tests/APIProviderTests.swift#L126 - cannot match several associated values at once, implicitly tupling the associated values and trying to match that instead

	Messages
📖	View more details on Bitrise
📖	AppStoreConnect-Swift-SDK: Executed 160 tests, with 0 failures (0 unexpected) in 0.413 (1.043) seconds

AppStoreConnect_Swift_SDK.framework: Coverage: 81.18

File	Coverage
ListAppInfosForApp.swift	97.22%	✅
ReadAppInfoOfApp.swift	100.0%	✅
ListAppStoreVersionsForApp.swift	94.29%	✅
AppRelationship.swift	100.0%	✅
AppStoreVersionRelationship.swift	0.0%	⚠️
AppInfoRelationship.swift	0.0%	⚠️
GetApp.swift	97.01%	✅
ListApps.swift	91.21%	✅

Generated by 🚫 Danger Swift against f554e3f

SwiftLeeBot · 2020-09-02T11:11:14Z

Sources/Models/AppStoreVersionRelationship.swift

+        case .build:
+            self = try .build(Build(from: decoder))
+        default:
+            fatalError()


⚠️ A fatalError call should have a message. (fatal_error_message)

AvdLee · 2020-09-02T11:23:38Z

I don't understand why the build fails. It doesn't look like the build has started on Bitrise.

This is related to Bitrise which only starts the build after manual approval from my side.

Regarding the errors, do you have them after doing a clean build locally?

MortenGregersen · 2020-09-02T19:13:19Z

Regarding the errors, do you have them after doing a clean build locally?

It builds fine on my machine when I do a clean build in both Xcode 11.7 and Xcode 12 beta 6. In Xcode 12 I get 158 warnings saying "Immutable property will not be decoded because it is declared with an initial value which cannot be overwritten" for the let type property on all the models.

…econnect-swift-sdk into app-info

cieslakdawid · 2020-10-03T19:58:13Z

@MortenGregersen I'm referring to AppStoreConnect-Swift-SDK.xcodeproj/project.pbxproj file.

For example the ListApp.swift is listed in source files and added to AppStoreConnect-Swift-SDK target. But as I don't see any changes that would add new files (e.g. AppInfo) to this target.

MortenGregersen · 2020-10-03T20:00:29Z

@MortenGregersen I'm referring to AppStoreConnect-Swift-SDK.xcodeproj/project.pbxproj file.

Got it. Didn't see the .xcodeproj in Githubs file list as it was shown as a folder... :) Maybe you are right.

cieslakdawid · 2020-10-03T20:03:46Z

@MortenGregersen Great! Looks like an easy fix, but let me know if I can help :)

MortenGregersen · 2020-10-03T20:24:00Z

I don't have the time to look at this right now. It would be awesome if you would try and add the files 👍

cieslakdawid · 2020-10-03T20:55:50Z

@MortenGregersen Sure - I've added source files, but there are also some tests failing. I'll take care of them tomorrow and update

- Sort files in the project file by the name

Add new files to the main target dependencies & update exected

cieslakdawid · 2020-10-04T11:39:19Z

Hey @AvdLee, can we ask to rerun the CI on the latest commit?
Hopefully, some errors will go away now.

cieslakdawid · 2020-10-04T16:47:42Z

Errors are gone, except the formatting one. Also looks like the coverage is quite low.
I might also help with that in upcoming days (probably Tue), unless you're a bit more available to finish up @MortenGregersen

MortenGregersen · 2020-10-04T17:32:22Z

Errors are gone, except the formatting one. Also looks like the coverage is quite low.

I might also help with that in upcoming days (probably Tue), unless you're a bit more available to finish up @MortenGregersen

Fantastic! Thank you for the help.

I don't have the time to do any work on this the following weeks.

github-actions · 2020-11-04T00:10:20Z

This PR is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days.

* Update GetAppTests for the new filtering options * Update ListAppsTests for the new filtering options * Update tests for AppRelationship * Add tests for generating the correct URL for ListAppStoreVersionsForApp endpoint * Remove `limit` parameter from ReadAppInfoOfApp (cannot be applied for this endpoint) * Fix the `appInfo` field key * Fix the method signature to reflect better the appropriate resource id * Add tests for ReadAppInfoOfAppTests endpoint * Fix AppInfo key * Add tests for ListapplnfosForApp for generating the correct URL * Remove duplicated white space * Comment out unimplemeted logic so the switch can be exhaustive

MortenGregersen · 2020-11-29T21:14:56Z

@AvdLee I can't remove the "Stale" label. The CI should be run on this PR again after the latest commit.

cieslakdawid · 2020-11-29T22:28:16Z

We got a little bit more tests & hopefully the linter error fixed, so ideally, the CI turns green and we can close this one :)

SwiftLeeBot · 2020-11-30T09:07:07Z

Sources/Models/AppStoreVersion.swift

+        public let data: AppStoreVersion.Relationships.AgeRatingDeclaration.Data?
+        public let links: AppStoreVersion.Relationships.AgeRatingDeclaration.Links
+
+        public struct Data: Codable {


⚠️ Types should be nested at most 1 level deep (nesting)

AvdLee · 2020-12-03T09:31:08Z

I think that we can ignore the nested types warnings here. I feel like it's useful in this case and helps to improve readability.

SwiftLeeBot · 2020-12-03T09:40:07Z

Sources/Models/AppStoreVersion.swift

+        public let data: AppStoreVersion.Relationships.AppStoreVersionLocalizations.Data?
+        public let links: AppStoreVersion.Relationships.AppStoreVersionLocalizations.Links?
+
+        public struct Data: Codable {


⚠️ Types should be nested at most 1 level deep (nesting)

cieslakdawid · 2020-12-03T09:42:04Z

I agree about nested types. Also, the CI went green, so hopefully, we can merge now.
Thanks both 👏

AvdLee · 2020-12-03T09:45:15Z

I had to merge in the base branch. Once CI succeeds again, I'll merge it in!

SwiftLeeBot · 2020-12-03T09:55:58Z

Sources/Models/AppStoreVersion.swift

+        public let data: AppStoreVersion.Relationships.AppStoreVersionSubmission.Data?
+        public let links: AppStoreVersion.Relationships.AppStoreVersionSubmission.Links?
+
+        public struct Data: Codable {


⚠️ Types should be nested at most 1 level deep (nesting)

SwiftLeeBot · 2020-12-03T09:55:58Z

Sources/Models/AppStoreVersion.swift

+            public let type: String = "appStoreVersionLocalizations"
+        }
+
+        public struct Links: Codable {


⚠️ Types should be nested at most 1 level deep (nesting)

SwiftLeeBot · 2020-12-03T10:04:37Z

Congratulations! 🎉 This was released as part of Release 1.2.0 🚀

Generated by GitBuddy

MortenGregersen added 17 commits August 22, 2020 22:12

Create ListAppInfosFoApp.swift

66b376c

Update ListAppInfosFoApp.swift

66acb33

Update ListAppInfosFoApp.swift

283d957

Move around

a8786cb

Update ListAppInfosForApp.swift

c1d8697

ReadAppInfoOfApp

2932152

Update ListApps.swift

d9e0150

Update ListApps.swift

2a9bf92

Update AppRelationship.swift

138f1db

Update AppInfo.swift

3e8da2c

AppStoreVersion

a053259

Update AppStoreVersionState.swift

82ba905

Update ListApps.swift

bd5ef32

Update ListApps.swift

d551f54

Clean

a9a7666

Update AppInfo.swift

1ca0989

Update AppInfo.swift

7bc50b4

MortenGregersen requested a review from AvdLee as a code owner August 31, 2020 20:42

AvdLee approved these changes Sep 1, 2020

View reviewed changes

Merge branch 'master' into app-info

4ca040a

MortenGregersen requested a review from SwiftLeeBot September 1, 2020 20:34

SwiftLeeBot reviewed Sep 2, 2020

View reviewed changes

MortenGregersen added 4 commits September 2, 2020 22:12

Update GetApp.swift

5a1d0e6

Merge branch 'app-info' of https://github.com/MortenGregersen/appstor…

53a7ee5

…econnect-swift-sdk into app-info

Create ListAppStoreVersionsForApp.swift

f15701a

Update ListAppStoreVersionsForApp.swift

614cba5

cieslakdawid and others added 3 commits October 4, 2020 13:17

- Add new files to the main target dependencies

f6e5ed0

- Sort files in the project file by the name

Update expected URLs in GetApp & ListApps tests

606e65b

Merge pull request #1 from cieslakdawid/app-info-add-sourcefiles

7fdd9a9

Add new files to the main target dependencies & update exected

Repository owner deleted a comment from MortenGregersen Oct 4, 2020

Repository owner deleted a comment from AvdLee Oct 4, 2020

github-actions bot added the Stale label Nov 4, 2020

github-actions bot removed the Stale label Nov 30, 2020

SwiftLeeBot reviewed Nov 30, 2020

View reviewed changes

Update incorrect expected url for the ListAppInfosForApp test (#3)

6702624

SwiftLeeBot reviewed Dec 3, 2020

View reviewed changes

Merge branch 'master' into app-info

f554e3f

SwiftLeeBot reviewed Dec 3, 2020

View reviewed changes

AvdLee merged commit 99eabd8 into AvdLee:master Dec 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

App Info and App Store Version #116

App Info and App Store Version #116

MortenGregersen commented Aug 31, 2020

MortenGregersen commented Aug 31, 2020

AvdLee left a comment

SwiftLeeBot commented Sep 1, 2020 •

edited

Loading

SwiftLeeBot Sep 2, 2020

AvdLee commented Sep 2, 2020

MortenGregersen commented Sep 2, 2020 •

edited

Loading

cieslakdawid commented Oct 3, 2020

MortenGregersen commented Oct 3, 2020 •

edited

Loading

cieslakdawid commented Oct 3, 2020

MortenGregersen commented Oct 3, 2020

cieslakdawid commented Oct 3, 2020

cieslakdawid commented Oct 4, 2020

cieslakdawid commented Oct 4, 2020

MortenGregersen commented Oct 4, 2020

github-actions bot commented Nov 4, 2020

MortenGregersen commented Nov 29, 2020

cieslakdawid commented Nov 29, 2020 •

edited

Loading

SwiftLeeBot Nov 30, 2020

AvdLee commented Dec 3, 2020

SwiftLeeBot Dec 3, 2020

cieslakdawid commented Dec 3, 2020

AvdLee commented Dec 3, 2020

SwiftLeeBot Dec 3, 2020

SwiftLeeBot Dec 3, 2020

SwiftLeeBot commented Dec 3, 2020

App Info and App Store Version #116

App Info and App Store Version #116

Conversation

MortenGregersen commented Aug 31, 2020

MortenGregersen commented Aug 31, 2020

AvdLee left a comment

Choose a reason for hiding this comment

SwiftLeeBot commented Sep 1, 2020 • edited Loading

AppStoreConnect_Swift_SDK.framework: Coverage: 81.18

SwiftLeeBot Sep 2, 2020

Choose a reason for hiding this comment

AvdLee commented Sep 2, 2020

MortenGregersen commented Sep 2, 2020 • edited Loading

cieslakdawid commented Oct 3, 2020

MortenGregersen commented Oct 3, 2020 • edited Loading

cieslakdawid commented Oct 3, 2020

MortenGregersen commented Oct 3, 2020

cieslakdawid commented Oct 3, 2020

cieslakdawid commented Oct 4, 2020

cieslakdawid commented Oct 4, 2020

MortenGregersen commented Oct 4, 2020

github-actions bot commented Nov 4, 2020

MortenGregersen commented Nov 29, 2020

cieslakdawid commented Nov 29, 2020 • edited Loading

SwiftLeeBot Nov 30, 2020

Choose a reason for hiding this comment

AvdLee commented Dec 3, 2020

SwiftLeeBot Dec 3, 2020

Choose a reason for hiding this comment

cieslakdawid commented Dec 3, 2020

AvdLee commented Dec 3, 2020

SwiftLeeBot Dec 3, 2020

Choose a reason for hiding this comment

SwiftLeeBot Dec 3, 2020

Choose a reason for hiding this comment

SwiftLeeBot commented Dec 3, 2020

SwiftLeeBot commented Sep 1, 2020 •

edited

Loading

MortenGregersen commented Sep 2, 2020 •

edited

Loading

MortenGregersen commented Oct 3, 2020 •

edited

Loading

cieslakdawid commented Nov 29, 2020 •

edited

Loading