MRPD - overflow of PDU to be transmitted bug

[andrew-elder]

In msrp.c, the logic to detect when a frame is "too full" is not correct. Crashes (segmentation faults) have been observed when many attributes are declared. The problem is that the conditional used in the while() loop to encode attributes is incorrect. This definitely applies to msrp_emit_XXXXX() functions. It may also apply to equivalent mvrp and mmrp functions.

[davidcemin]

so to reproduce this issue I just have to declare several attributes?

[andrew-elder]

On 10/22/2014 11:06 AM, David Cemin wrote:

so to reproduce this issue I just have to declare several attributes?

—
Reply to this email directly or view it on GitHub
#100 (comment).

If you change the line below to initialize count to 256 it will happen.
https://github.com/AVnu/Open-AVB/blob/open-avb-next/daemons/mrpd/tests/simple/msrp_tests.cpp#L149

Actually, you'll run into one other bug first, but in principle that is all
you need to do.
I need to fix and close out issue#100 before I can continue to work on this
issue.
And I need to add mvrp and mmrp unit tests for issue#100 as well to make
sure that they are covered.

Andrew Elder
AudioScience, Inc.
+1-585-271-8870
www.audioscience.com