linux_hal_common: the resources (sd_*) not freed (SCA _002/_003/_017 #38/#39/#51) #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PawelModrzejewski
force-pushed
the
issue_38_39_sockets_not_freed
branch
from
e537a84
to
5544f08
Compare
PawelModrzejewski
changed the title
|
Please review/comment. |
…vnu#38/Avnu#39/Avnu#51) Static code analysis fix _002 _003 _017 (Issues Avnu#38 Avnu#39 Avnu#51) Added sd_general and sd_event initalization in LinuxNetworkInterface() constructor; now sockets can be properly closed in relevant destructor code, which was not called at all in case of failures. ifname initialization moved up to solve compilation error ("jump to label 'exit_error' crosses initialization of 'InterfaceName* ifname")
PawelModrzejewski
force-pushed
the
issue_38_39_sockets_not_freed
branch
from
5544f08
to
e1f2a1b
Compare
PawelModrzejewski
changed the title
avinash-palleti
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static code analysis fixes _002 _003 _017 (Issues #38 #39 #51)
Added sd_general and sd_event initalization in LinuxNetworkInterface() constructor; now sockets can be properly closed in relevant destructor code, which was not called at all in case of failures.
ifname initialization moved up (net_lock.init() down) to solve compilation error ("jump to label 'exit_error' crosses initialization of 'InterfaceName* ifname")