Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): agent - add the table component with its pagination #153

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

JLou
Copy link
Contributor

@JLou JLou commented Feb 20, 2024

image

.vscode/settings.json Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
packages/react/src/Table/Pagination/Li.tsx Outdated Show resolved Hide resolved
packages/react/src/Table/Pagination/Next.tsx Outdated Show resolved Hide resolved
packages/react/src/Table/Pagination/Previous.tsx Outdated Show resolved Hide resolved
packages/react/src/Table/Pagination/Previous.tsx Outdated Show resolved Hide resolved
packages/react/src/Table/Table.stories.tsx Outdated Show resolved Hide resolved
@JLou JLou added this to the 1.0.0 milestone Feb 22, 2024
@JLou JLou linked an issue Feb 22, 2024 that may be closed by this pull request
@JLou JLou added the agent-slash Component for the agent theme label Feb 22, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment ce fait il que le package lock sois update sans ajout de package ou modification des package.json ?

packages/react/src/Table/Pagination/Items.tsx Show resolved Hide resolved
packages/react/src/Table/Pagination/Items.tsx Show resolved Hide resolved
packages/react/src/Table/Pagination/Li.tsx Show resolved Hide resolved
packages/react/src/Table/Pagination/Pager.tsx Show resolved Hide resolved
Triki-Ahmed
Triki-Ahmed previously approved these changes Mar 28, 2024
@JLou JLou dismissed stale reviews from Triki-Ahmed and GuillaumeKESTEMAN via 9ee74db April 10, 2024 07:51
@JLou JLou force-pushed the feature/table branch 2 times, most recently from 9ee74db to d1e19d0 Compare April 10, 2024 08:42
MartinWeb
MartinWeb previously approved these changes Jul 16, 2024
margin: 1rem auto;
text-align: center;

[class^="col"] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[class^="col"] a quoi de plus par rapport à un simple .col ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ca permet de target tout ce qui commence par col, donc col-sm-2 par exemple. Je n'en sais pas plus, mais ca a permis de fixer une erreur :

@JLou JLou merged commit 0f47ec5 into main Jul 16, 2024
1 check passed
@JLou JLou deleted the feature/table branch July 16, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-slash Component for the agent theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component Table
5 participants