-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added strategies Desperate, Willing, Hopeless, Grim #686
Conversation
Looks good to me, just missing 4791d13 which adds the new module to the autodoc of the strategies. |
@ranjinidas is going to set the initial plays to random as well, then I think it's ready to merge! |
@marcharper and @drvinceknight Can I commit to this PR? Or should I open a new one? I would have to squash all my commits again in that case. |
@ranjinidas You can add to this one. |
Can she? Does @ranjinidas have push access to the |
If you can't push @ranjinidas, you can make a new branch off this one and open a PR from that branch to this one. |
I merged local master with upstream/mutual, then ran git push -u origin upstream/mutual (clearly this was wrong. because it didn't update). How should I push upstream/mutual? |
Well it's a bit of mess since I squashed these commits already. Here's what you'll need to do.
Make any new commits on mutual2, then push mutual2 to your fork and open a pull request from rajinidas/mutual2 to origin/mutual (use "compare across forks"). Let me know if any issues come up! If you have troubles I can |
@marcharper Thanks so much for your help! I'll try this today and let you know if there are any issues. |
This is ready for review -- I grabbed @ranjinidas latest commits and added a few more tests. |
|
||
def test_strategy(self): | ||
seed(1) | ||
self.first_play_test(C) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also check that D is sometimes played?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And for the other two.
Suggestion: instead of a seed could just play 20 first plays and check that both C and D are in there.
Ok I'll add these in a bit. |
Adding tests Desperate, Hopeless, Willing and Grim in mutual.py
Tests and references added; rebased for bibliography. |
Looks great. Thanks @ranjinidas! |
Adding strategies/tests Desperate, Hopeless, Willing and Grim in mutual.py
This is a rebase of PR #683 by @ranjinidas