Additions to Plots #791
Merged
Additions to Plots #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing matplotlib axes. Giving access to the matplotlib axes of the plots in the library. If user does not specify the axes then it uses `plt.subplots`. Some measures, such as number of players, players etc were used in more than one plot so I initiliaze them in the class. Also, I have not yet removed the title argument because I am not sure if is needed for when running our tournament and saving the plots. Please let me know you suggestions.
Addressing the error. Taken from: sphinx-doc/sphinx#3212
drvinceknight
requested changes
Dec 12, 2016
| @@ -15,6 +15,7 @@ install: | |||
| - pip install -r requirements.txt | |||
| - pip install sphinx | |||
| - pip install sphinx_rtd_theme | |||
| - pip install docutils==0.12 | |||
There was a problem hiding this comment.
Travis was failing because of this error:
assert not self.context, 'len(context) = %s' % len(self.context)
AssertionError: len(context) = 1```
and i just followed the sphinx issues where they said you need to also install this.
drvinceknight
approved these changes
Dec 12, 2016
I suggest leaving this as it is for the sake of backwards compatibility. |
|
Looks good to me, I'll wait on @drvinceknight's title question to merge, or merge with my blessing as you wish. |
|
If you're happy I'm happy. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #776
Passing matplotlib axes.
Giving access to the matplotlib axes of the plots
in the library. If user does not specify the axes
then it uses
plt.subplots.Some measures, such as number of players, players
etc were used in more than one plot so I initiliaze
them in the class. Also, I have not yet removed the
title argument because I am not sure if is needed
for when running our tournament and saving the plots.
Please let me know you suggestions.