Added partial DRM system support. Some typo fixes. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersaares
suggested changes
Nov 22, 2018
There was a problem hiding this comment.
Review summary of most important points:
- The term "DRM system" is misapplied, needs correction.
- Let's implement the entire element, please. It is a very simple element, after all.
- If we now support this element, we should add it to the test vectors generator, improving some existing examples and adding new ones. Maybe reference the work by Laurent, maybe make up own examples - I have not thought about what makes good examples yet.
- Code looks nice and clean!
I did not check it from a "did anything not get touched that should have" angle. I guess readme should be updated to match new features.
- Also added a unique constraint and a default value related HLSSignalingData element and "playlist" attribute. This way schema validation fails if multiple playlist value are the same (even of both not present).
sandersaares
suggested changes
Nov 29, 2018
- Automatic PR data signaling generation. Much of code was taken from Makemedia and Axinom.Toolkit projects, with some modifications. This doesn't cover HDS and SS data generation. - Added Protobuf lib as dependency, for Widevine PSSH data generation. - "Variant" playlist renamed to "Media" playlist as per HLS spec.
sandersaares
approved these changes
Nov 30, 2018
Cpix/HlsPlaylistType.cs
Outdated
| @@ -3,6 +3,6 @@ | |||
| public class HlsPlaylistType | |||
There was a problem hiding this comment.
Any particular reason this is not a sealed class? Feels like it should be.
There was a problem hiding this comment.
No reason. Will seal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The partial support includes: key ID, system ID and content protection data handling.