-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement aggregate lifecycle helper functions #72
Implement aggregate lifecycle helper functions #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is provided looks fine, but I am uncertain why you haven't added the other static operations from the AggregateLifecycle
class with it. So, things like isLive
, getVersion
and markDeleted
. Especially the last one is pretty important if the life cycle of an aggregate actually ends.
Since the methods So in Kotlin code it will look like:
I see no value in providing the same functions and just change the import. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Aaaah gotcha, I completely missed the point of collision in your original issue description. Could be me, could be the description; in the end it doesn't matter, as I feel that what you've done is fine as is. Thanks for clarifying @zambrovski. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My concerns have been addressed, hence approving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
fix #71