Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove } from RestCapabilityDiscoverMode constant #352

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Remove } from RestCapabilityDiscoverMode constant #352

merged 1 commit into from
Feb 12, 2024

Conversation

aaklilu
Copy link
Contributor

@aaklilu aaklilu commented Feb 12, 2024

The member-capabilities constant contains an extra } which causes a problem if one creates the RestCapabilityDiscoverMode using the builder manually.

@aaklilu
fix: remove } from member-capabilities constant
d9c5d02 
The member-capabilities constant contains an extra } which causes a problem if one creates the RestCapabilityDiscoverMode using the builder manually.
@CLAassistant
Copy link

CLAassistant commented Feb 12, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@aaklilu aaklilu marked this pull request as draft February 12, 2024 08:15
@aaklilu aaklilu marked this pull request as ready for review February 12, 2024 08:16
@smcvb smcvb requested review from a team, gklijs, CodeDrivenMitch and smcvb and removed request for a team February 12, 2024 12:44
@smcvb smcvb added this to the Release 4.10.0 milestone Feb 12, 2024
@smcvb smcvb changed the title fix: remove } from member-capabilities constant fix: Remove } from member-capabilities constant Feb 12, 2024
@smcvb smcvb changed the title fix: Remove } from member-capabilities constant Remove } from RestCapabilityDiscoverMode constant Feb 12, 2024
smcvb
smcvb approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find, @aaklilu! And, thanks for providing a fix. The help is much appreciated :-)

@smcvb smcvb merged commit 2b3eae9 into AxonFramework:master Feb 12, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcvb smcvb smcvb approved these changes

@gklijs gklijs Awaiting requested review from gklijs gklijs was automatically assigned from AxonFramework/framework-developers

@CodeDrivenMitch CodeDrivenMitch Awaiting requested review from CodeDrivenMitch CodeDrivenMitch was automatically assigned from AxonFramework/framework-developers

Assignees

@aaklilu aaklilu

Labels
Priority 2: Should Status: In Progress Type: Bug
Projects
None yet
Milestone
Release 4.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aaklilu @CLAassistant @smcvb