-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added docs for token reset #273
Conversation
9f060e0
to
c0c6bcb
Compare
c0c6bcb
to
db03019
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bunch of comments to process!
Now, when `resetTokens()` is called, the executing instance can temporarily claim all segments, reset the tokens and store the new values. | ||
After the token has been reset, the event processor can be started again. | ||
|
||
Note that older versions of axon framework (pre 4.6) directly acknowledge a received admin instruction, without waiting for its execution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Giving mention to versions shouldn't be necessary in the documentation, because users can select the version of the doc.
Thus, if they open 4.5, they'll get docs complying to that version. When opening 4.6 (soon to come), they'll receive descriptions applicable to 4.6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My concerns have been addressed, hence I'm approving this pull request.
Documentation on how to reset event processor tokens using AF, AS Rest API or AS Connector.
See also the PR in the samples repo.