Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs for token reset #273

Merged
merged 3 commits into from
Aug 4, 2022
Merged

Added docs for token reset #273

merged 3 commits into from
Aug 4, 2022

Conversation

trimoq
Copy link
Collaborator

@trimoq trimoq commented Jul 4, 2022

Documentation on how to reset event processor tokens using AF, AS Rest API or AS Connector.
See also the PR in the samples repo.

@trimoq trimoq force-pushed the feature/event-processor-reset branch from 9f060e0 to c0c6bcb Compare July 18, 2022 15:11
@trimoq trimoq force-pushed the feature/event-processor-reset branch from c0c6bcb to db03019 Compare July 18, 2022 15:14
Copy link
Collaborator

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bunch of comments to process!

axon-server/administration/reset-event-processor-token.md Outdated Show resolved Hide resolved
Now, when `resetTokens()` is called, the executing instance can temporarily claim all segments, reset the tokens and store the new values.
After the token has been reset, the event processor can be started again.

Note that older versions of axon framework (pre 4.6) directly acknowledge a received admin instruction, without waiting for its execution.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving mention to versions shouldn't be necessary in the documentation, because users can select the version of the doc.
Thus, if they open 4.5, they'll get docs complying to that version. When opening 4.6 (soon to come), they'll receive descriptions applicable to 4.6.

axon-server/administration/reset-event-processor-token.md Outdated Show resolved Hide resolved
axon-server/administration/reset-event-processor-token.md Outdated Show resolved Hide resolved
axon-server/administration/reset-event-processor-token.md Outdated Show resolved Hide resolved
axon-server/administration/reset-event-processor-token.md Outdated Show resolved Hide resolved
axon-server/administration/reset-event-processor-token.md Outdated Show resolved Hide resolved
axon-server/administration/reset-event-processor-token.md Outdated Show resolved Hide resolved
axon-server/administration/reset-event-processor-token.md Outdated Show resolved Hide resolved
axon-server/administration/reset-event-processor-token.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concerns have been addressed, hence I'm approving this pull request.

@trimoq trimoq marked this pull request as ready for review July 25, 2022 08:02
@trimoq trimoq merged commit 00a1109 into master Aug 4, 2022
@smcvb smcvb deleted the feature/event-processor-reset branch August 5, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants