[draft] NATS #2
Draft
[draft] NATS #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sravan-s
force-pushed
the
feat/nats
branch
3 times, most recently
from
45256cf
to
1eaa9a0
Compare
AyWa
commented
Aug 13, 2023
sravan-s
reviewed
Aug 13, 2023
| #[serde(deny_unknown_fields)] | ||
| pub struct NatsSourceParams { | ||
| /// The subject that the source consumes. | ||
| pub subject: String, |
There was a problem hiding this comment.
I was checking how people subscribe to multiple subjects ->
nats-io/nats-server#2515
nats-io/nats-server#3500
There was a problem hiding this comment.
I guess lets support that when it is implemented in nats
There was a problem hiding this comment.
Looks like we dont need to do anything..
But, anyways ~ do you know their branching strategy with dev branch(?) probably dev is for v3?
There was a problem hiding this comment.
Ah, its for next minor version -> 2.10 probably
sravan-s
reviewed
Aug 13, 2023
| /// The subject that the source consumes. | ||
| pub subject: String, | ||
| /// The connection URI for NATS. | ||
| pub address: Vec<String>, |
There was a problem hiding this comment.
https://docs.rs/async-nats/0.31.0/async_nats/fn.connect.html#with-vec-but-parse-urls-inside-crateconnect this seems to be straightforward?
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In different PR:
add test for nats
implementation with jetstream (need to do ack etc -> at least once)