Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxonomy pages problem #18

Closed
Stiofan opened this issue Sep 21, 2017 · 1 comment
Closed

Taxonomy pages problem #18

Stiofan opened this issue Sep 21, 2017 · 1 comment

Comments

@Stiofan
Copy link
Contributor

Stiofan commented Sep 21, 2017

Hi Kiran, (tagging Paolo also in case he has any feedback)

My idea of hijacking the first the_post loop and then setting our own one still has the problem that it will output the first item of the loop at the end and there is no easy way to remove it.

My other idea is two parts, we give the option of two views:
#1 We just filter the_content on the archive page and add our own stuff

  • : Easy, will work with 99% of themes out the box.
  • : We don't have our option to change the view, grid12345/list, we are stuck with the theme layout which i guess might be a positive for some but we wont have a "standard" GD category layout.

#2 We copy the theme archive.php and store it somewhere and use some regex to replace the loop code with our own which would be wrapped in our wrappers and use our own get_template_part('listing','list');

  • We can use our own templates and can use our grid/list views
  • Might not work perfect with all themes.
@Stiofan
Copy link
Contributor Author

Stiofan commented Sep 22, 2017

I have pushed a fix for this, we still need to filter the page title and use the new "GD Archive" page template content but its working for now and working well in most themes tested.

@Stiofan Stiofan closed this as completed Jan 9, 2018
Stiofan pushed a commit that referenced this issue Jan 22, 2018
terms and conditions added
Stiofan pushed a commit that referenced this issue Apr 10, 2018
Stiofan pushed a commit that referenced this issue Mar 14, 2019
kprajapatii added a commit that referenced this issue Feb 25, 2020
kprajapatii added a commit that referenced this issue Oct 7, 2020
kprajapatii added a commit that referenced this issue May 13, 2021
kprajapatii added a commit that referenced this issue Oct 6, 2022
kprajapatii added a commit that referenced this issue Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants