post_install.sh: create ags symlink relative to Root directory #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating the ags executable as an absolute symlink to $DESTDIR/$2/$APP_ID breaks staged installs, where the installed files are not placed directly into their expected location but are instead copied into a temporary location (DESTDIR). Since installed files maintain their relative directory structure and any embedded file names will not be modified, we can create a relative symlink instead, which fixes the issue. It has the added benefit that the link target remains valid, even if the storage device underlying this program is mounted into a subdirectory of the root filesystem (e.g. for recovery). Bug: gentoo/guru#212
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was reported by a Gentoo user: gentoo/guru#212
Creating the ags executable as an absolute symlink to
$DESTDIR/$2/$APP_IDbreaks staged installs, where the installed files are not placed directly into their expected location but are instead copied into a temporary location (DESTDIR). Since installed files maintain their relative directory structure and any embedded file names will not be modified, we can create a relative symlink instead, which fixes the issue.It has the added benefit that the link target remains valid, even if the storage device underlying this program is mounted into a subdirectory of the root filesystem (e.g. for recovery).