only destroy children that aren't re-used #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aylur
reviewed
Aug 23, 2023
src/widgets/overlay.ts
Outdated
| @@ -61,4 +69,9 @@ export default class AgsOverlay extends Gtk.Overlay { | |||
| this._overlays.push(widget); | |||
| super.add_overlay(widget); | |||
| } | |||
|
|
|||
| remove_overlay(widget: Gtk.Widget): void { | |||
There was a problem hiding this comment.
remove_overlay is a gtk4 thing, not gtk3
you can probably do remove(widget) just like in box
|
I'll sort linting and overlay tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first PR to an open-source project, let me know if there's anything I need to add/do.
When the children array or child is set on any widget, only widgets that aren't also in the new array should be destroyed.
There may be cases where widgets are being re-used (eg.. images that are created and cached in a service) - destroying them before re-adding them causes errors.
NOTE: I don't know why typescript is complaining that remove_overlay doesn't exist on Overlay widget, it's in the docs.. See commented out code.