Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upstream] Pages texts #1723

Merged
merged 5 commits into from
Nov 26, 2018
Merged

[Upstream] Pages texts #1723

merged 5 commits into from
Nov 26, 2018

Conversation

decabeza
Copy link

References

consuldemocracy#3042

Objectives

  • Improves pages markup. Uses i18n keys complete and " instead of ' for example t("pages.title.conditions") instead of t('.conditions').

  • Removes unnecessary pages. Forks can create any page they need, I removed census_terms and general_terms because there were empty and untranslated.

  • Removes custom texts. I removed some example texts referencing to Spanish laws to avoid confusing translators.

  • Removes references to deleted general terms page.

  • Creates census terms custom page.

Does this PR need a Backport to CONSUL?

Backport Removes references to deleted general terms page commit to CONSUL repo.

@decabeza decabeza added this to Review in Roadmap Nov 22, 2018
Copy link
Member

@voodoorai2000 voodoorai2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@decabeza decabeza merged commit 0881c32 into master Nov 26, 2018
@decabeza decabeza deleted the pages-texts branch November 26, 2018 14:06
@decabeza decabeza moved this from Review to Backport in Roadmap Nov 30, 2018
@decabeza decabeza self-assigned this Nov 30, 2018
@decabeza decabeza moved this from Backport to Done in Roadmap Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants