Pages texts #3042
Merged
Pages texts #3042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decabeza
force-pushed
the
pages-texts
branch
from
84916b2
to
952586d
Compare
javierm
approved these changes
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
Improves pages markup. Uses i18n keys complete and
"instead of'for examplet("pages.title.conditions")instead oft('.conditions').Removes unnecessary pages. Forks can create any page they need, I removed
census_termsandgeneral_termsbecause there were empty and untranslated.Removes custom texts. I removed some example texts referencing to Spanish laws to avoid confusing translators.