Consider having valuator group as having valuator #1791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So under the tab "without valuator" we don't show investments assigned to a valuator group, just as expected by administrators.
javierm
force-pushed
the
without_valuator
branch
from
d6d15db
to
b96697a
Compare
houndci-bot
reviewed
Jan 9, 2019
| @@ -63,7 +63,8 @@ class Investment < ActiveRecord::Base | |||
|
|
|||
| scope :valuation_open, -> { where(valuation_finished: false) } | |||
| scope :without_admin, -> { valuation_open.where(administrator_id: nil) } | |||
| scope :without_valuator, -> { valuation_open.where(valuator_assignments_count: 0) } | |||
| scope :without_valuator_group, -> { where(valuator_group_assignments_count: 0) } | |||
| scope :without_valuator, -> { valuation_open.without_valuator_group.where(valuator_assignments_count: 0) } | |||
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [121/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)
voodoorai2000
approved these changes
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
Make the tab "without valuator" really mean "without valuator nor valuator group", just as expected by administrators.
Does this PR need a Backport to CONSUL?
Yes.