Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consul pull ⬇️ #891

Merged
merged 46 commits into from
Sep 25, 2017
Merged

Consul pull ⬇️ #891

merged 46 commits into from
Sep 25, 2017

Conversation

bertocq
Copy link

@bertocq bertocq commented Sep 22, 2017

Where

Consul PR's::

What

  • Pulls latest changes from Consul

How

  • Carefully merging manually.

Screenshots

No need, check PR's

Test

Deployment

  • To pre, test, and then merge this.

Warnings

  • We're removing with this PR the FinalRecount model and its table... We've already a PR to stash all First 2017 Poll results/stats/info/landing that should be merged Stash first 2017 Poll #885

bertocq and others added 30 commits September 19, 2017 00:45
Why:

* IDE/Text editor specific files and folders to be ignored should be on each developer's personal .gitignore_global file

How:

* If you're affected by this change, check https://help.github.com/articles/ignoring-files/#create-a-global-gitignore
Reactivates feature setting after spec
Using correct resource in path
Visits directly the page to avoid flakiness
Maybe using `build` instead of `create` was confusing the spec
Adds random number to the proposal’s title, to avoid js popup
displaying similar proposals
Usually the first spec that visits a page fails with a timeout.
Hopefully it was due to having to compile assets at runtime and this helps to fix it
Remove Poll Final Recounts, replace with Total Results
Copy link
Member

@voodoorai2000 voodoorai2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@bertocq bertocq merged commit acd3ec8 into master Sep 25, 2017
@bertocq bertocq deleted the consul_pull branch September 25, 2017 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants