-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: historic access data tree #2585
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LHerskind
force-pushed
the
lh/historic_storage_access
branch
from
September 29, 2023 10:52
0439971
to
c56ea1c
Compare
LHerskind
force-pushed
the
lh/historic_storage_access
branch
from
September 29, 2023 12:34
9a255d1
to
445b628
Compare
4 tasks
This change can now be reverted since we have now migrated over to the new pedersen implementation |
Closed in favor of #3159 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2584 as part of #2572
hash_multiple
to follow the version used in noir (plookup_commit
).getCommitmentIndex
andfindCommitmentIndex
tofindCommitmentIndex
getMembershipWitness
oracle which currently provides both index and path. It only works for the data tree atm, but as part of Use historic roots from noir #2572 should be made to work with the other trees.Uses an
AlmostValueNote
as input since the macro is using theserialize
function, which forValueNote
don't include the header so it is invalid.Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.