refactor: cleanup of abi.nr in aztec-nr

[benesjan]

Cleanup of abi.nr + removing PublicGlobalVariables struct since it's a copy of GlobalVariables.

[benesjan]

Current dependencies on/for this PR:

• master
  • PR feat: updating global vars with fees #4421
    • PR refactor: cleanup of abi.nr in aztec-nr #4473 👈
      • PR test: testing all values in PublicGlobalVariables and PrivateGlobalVariables #4481
        • PR chore: simulator utils cleanup #4507
          • PR test: testing historical header in contexts #4509
            • PR refactor: aligning some naming in BaseOrMergeRollupPublicInputs #4510

This stack of pull requests is managed by Graphite.

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_trial_decrypting_time_in_ms (32): 118 (+179%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 295cd556 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,700	180,580	720,100
l1_rollup_calldata_gas	222,772	871,276	3,464,464
l1_rollup_execution_gas	315,963	989,724	3,684,842
l2_block_processing_time_in_ms	1,154 (-1%)	4,362 (-7%)	17,268
note_successful_decrypting_time_in_ms	323	991 (-5%)	3,683 (-1%)
note_trial_decrypting_time_in_ms	38.3 (+14%)	⚠️ 118 (+179%)	136 (-6%)
l2_block_building_time_in_ms	17,773 (-1%)	70,264 (-1%)	281,824 (-1%)
l2_block_rollup_simulation_time_in_ms	13,068 (-1%)	51,640	207,636 (-1%)
l2_block_public_tx_process_time_in_ms	4,676 (-1%)	18,546 (-1%)	73,928 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,629 (-1%)	26,069 (-1%)
note_history_successful_decrypting_time_in_ms	2,540 (+8%)	4,837 (+4%)
note_history_trial_decrypting_time_in_ms	90.0 (-12%)	166 (-28%)
node_database_size_in_bytes	17,293,392	33,079,376
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	308	44,528	25,825
private-kernel-ordering	194	44,145	16,225
base-rollup	1,404	128,654	933
root-rollup	82.3 (-3%)	4,192	729
private-kernel-inner	437	71,331	25,825
public-kernel-private-input	240	32,287	25,825
public-kernel-non-first-iteration	236	32,329	25,825
merge-rollup	7.88 (-1%)	2,712	933

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	128 leaves	64 leaves	512 leaves	1024 leaves	2048 leaves	8192 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.2	11.3 (+7%)	12.7	16.9	26.1 (+14%)	63.8	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	143	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.595	0.629 (+6%)	0.540	0.524	0.547 (+14%)	0.440	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	74.5	47.5	238 (-1%)	461	899	3,551
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	159	96.0	543	1,055	2,079	8,223
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.460	0.487	0.435	0.432	0.428	0.427
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	103	56.4	351	685	1,368	5,417
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	197	104	691	1,363	2,707	10,771
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.492	0.495	0.475	0.472	0.474	0.470
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	56.3	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	94.1	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	0.577	N/A	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	16,859	40,167

Transaction processing duration by data writes.

Metric	0 new commitments	1 new commitments
tx_pxe_processing_time_ms	550 (-1%)	1,302

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	0.518 (-1%)	574

[LHerskind]

LGTM. Feel free to merge when it passes the e2e_deployment_contract. Might be a rebase issue, not seeing how it matches your changes.