feat: PG + Goblin

[ledwards2225]

Implements a new ClientIvc class that serves as the interface for doing IVC with PG + Goblin. Adds a PoC for the architecture in new test file. This test (and an updated one for Goblin + vanilla recursion) use a new goblin method merge which is similar to the accumulate method but with the IVC prover related work stripped out. This allows goblin to be completely agnostic to the IVC scheme (recursion/folding) that it's being used with.

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_trial_decrypting_time_in_ms (32): 112 (+140%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 99c3fbad and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,700	180,580	720,100
l1_rollup_calldata_gas	222,820	871,216	3,465,844
l1_rollup_execution_gas	316,011	989,664	3,686,222
l2_block_processing_time_in_ms	1,151 (-2%)	4,330 (-1%)	17,175 (-1%)
note_successful_decrypting_time_in_ms	312 (-5%)	979 (-4%)	3,644 (-5%)
note_trial_decrypting_time_in_ms	23.0 (-40%)	⚠️ 112 (+140%)	146 (-2%)
l2_block_building_time_in_ms	17,835	70,310	281,953
l2_block_rollup_simulation_time_in_ms	13,125	51,674	208,028
l2_block_public_tx_process_time_in_ms	4,682	18,557 (-1%)	73,665 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,725	26,334 (-1%)
note_history_successful_decrypting_time_in_ms	2,349 (-1%)	4,597 (-2%)
note_history_trial_decrypting_time_in_ms	104 (+18%)	222 (+23%)
node_database_size_in_bytes	17,317,968	33,062,992
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	308 (+1%)	44,528	25,825
private-kernel-ordering	194 (-1%)	44,145	16,225
base-rollup	1,405	128,654	933
root-rollup	82.3 (-1%)	4,192	729
private-kernel-inner	436	71,331	25,825
public-kernel-private-input	240	32,287	25,825
public-kernel-non-first-iteration	236	32,329	25,825
merge-rollup	7.83 (-2%)	2,712	933

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	128 leaves	64 leaves	512 leaves	1024 leaves	2048 leaves	8192 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.2	11.2 (-17%)	12.7	17.0 (+1%)	22.7 (-1%)	64.0	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	143	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.595	0.626 (-17%)	0.539	0.526 (+1%)	0.477 (-1%)	0.442	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	78.6 (-2%)	47.6	239 (-2%)	460	896 (-1%)	3,545 (-1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	159	96.0	543	1,055	2,079	8,223
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.486	0.489	0.436 (-2%)	0.431	0.427	0.427
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	107 (+3%)	56.9	349 (-1%)	684 (-1%)	1,357 (-1%)	5,397 (-1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	197	104	691	1,363	2,707	10,771
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.510 (+3%)	0.499	0.473 (-1%)	0.472	0.472 (-1%)	0.470
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	56.5	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	94.1	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	0.578	N/A	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	16,859	40,167

Transaction processing duration by data writes.

Metric	0 new commitments	1 new commitments
tx_pxe_processing_time_ms	551	1,301 (-1%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	0.515 (-24%)	574 (-1%)

[codygunton]

Small requests, nothing blocking, thanks for this.

[codygunton]

Will you rename this file to client_ivc.test.cpp?

[codygunton]

This flag was preventing my CMakeTools from building... I guess removing it didn't give you problems?