chore: add goblin ops in add_gates_to_ensure_all_polys_are_non_zero

[maramihali]

Resolves AztecProtocol/barretenberg#843.

Removes the need to add golin ecc ops for each UGH circuit by
ensuring we add the dummy gates as part of the function used to ensure
other polynomials are non-zero due to the absence of specific gates. However, we keep adding goblin ecc gates
to circuits in situations when we want to test Goblin and also in ClientIVC because merge proving is done prior to ProverInstance creation.

[ledwards2225]

Overall I think this is a good step but I think we need to make an important distinction between the UGH context and the Goblin context. (see my review comments for more detail on what I mean). This is probably my fault for inappropriately labelling some of the Goblin cases with a TODO when this really only applies to UGH.

[ledwards2225]

The comments on this function may be a bit confusing/misleading - maybe we can change to say something like "default gates added to avoid nonzero polynomials will bump size to next power of 2"

[ledwards2225]

Its debatable whether we should remove the ops here. In the case of UGH, removing them is fine since eventually we'd like a world where we dont NEED goblin ops to make a valid proof. This one, however, is a Goblin specific test so it would defeat the purpose of the test to not have any ops. So when/if we get rid of the add_gates_to_ensure.., this test would be quietly made useless. I think we should continue to explicitly add ops here in one way or another, with a comment explaining why, so someone who thinks they're clever doesn't go and remove them later. What do you think?

[ledwards2225]

Same here

[ledwards2225]

Maybe we should keep this function but expand it to include at least one of each type of op (mul, add, eq) and use this in the Goblin-specific places I mentioned to continue to ensure we're getting robust testing that's not implicitly tied to the _add_gates_to_ensure functionality.

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 54aee589 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	676	676	676
l1_rollup_calldata_gas	6,424	6,400	6,424
l1_rollup_execution_gas	585,757	585,733	585,757
l2_block_processing_time_in_ms	1,268 (-3%)	4,502 (-6%)	8,988 (-3%)
note_successful_decrypting_time_in_ms	171 (+6%)	512 (-4%)	959 (-1%)
note_trial_decrypting_time_in_ms	81.0 (+20%)	31.2 (-46%)	130 (+35%)
l2_block_building_time_in_ms	13,623	49,926 (-1%)	99,315 (-1%)
l2_block_rollup_simulation_time_in_ms	7,850 (-1%)	27,673	54,419
l2_block_public_tx_process_time_in_ms	5,751	22,201 (-2%)	44,772 (-2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,751 (-4%)	26,581 (-1%)
note_history_successful_decrypting_time_in_ms	1,221 (-11%)	2,431 (-2%)
note_history_trial_decrypting_time_in_ms	64.3 (-41%)	151 (-4%)
node_database_size_in_bytes	18,628,688	35,033,168
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	225 (-1%)	44,379	28,214
private-kernel-ordering	200	52,880	14,296
base-parity	3,489 (-2%)	128	311
root-parity	1,287 (+10%)	1,244	311
base-rollup	16,324	165,760	861
root-rollup	49.2	4,359	725
private-kernel-inner	292 (-1%)	73,795	28,214
public-kernel-app-logic	120 (-1%)	35,252	28,217
public-kernel-tail	164 (-1%)	40,928	28,217
merge-rollup	8.13 (-3%)	2,568	861
public-kernel-teardown	117 (-2%)	35,252	28,217
public-kernel-setup	116 (-1%)	35,252	28,217

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.0	16.0 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.586	0.493	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	47.7 (+1%)	72.4	232	444 (-1%)	870 (-1%)	1,724	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.489 (+1%)	0.446	0.421	0.415	0.414 (-1%)	0.413	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	54.4 (-2%)	106 (-2%)	340 (-1%)	657 (-1%)	1,310 (-1%)	2,628	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.479 (-2%)	0.480 (-1%)	0.463	0.453 (-1%)	0.453	0.458	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.2
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.534

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	14,968	495,320

Transaction size based on fee payment method

Metric	none fee payment method	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	773	905	1,161	1,377

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	2,080	1,352 (-1%)	4,702 (-1%)

Metric	0 public data writes	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	10.4 (+2%)	695 (-1%)	523	1,434	581	2,489 (-1%)	668 (-1%)

[ledwards2225]

Looks good - thanks for the updates!