refactor: add uint (U128) note to aztec-nr and remove OwnedNote from ValueNote

[sklppy88]

In this PR we are just adding a new note type to aztec-nr. This is simply tokennote, but we are doing the addition of this note and the removal of tokennote in two steps to make the diffs easier to understand. This also removes OwnedNote from ValueNote.

Sets up resolving of #8107.

[sklppy88]

• refactor: replace token note with uint note #8143
• refactor: add uint (U128) note to aztec-nr and remove OwnedNote from ValueNote #8142 👈
• refactor: add partial note support for value note #8141
• refactor: rework balances map #8127
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sklppy88 and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• avm_simulation_time_ms (Token:transfer_public): 36.6 (+74%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,749	1,568	717	768 (+4%)	776 (+1%)
proof_construction_time_sha256_30_ms	11,513	3,093	1,385	1,419 (-1%)	1,467
proof_construction_time_sha256_100_ms	44,227	11,859 (+1%)	5,498 (+1%)	5,413	5,835
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	59.0 (+2%)	87.0 (-1%)
proof_construction_time_poseidon_hash_30_ms	1,528	422	203 (-1%)	232 (+3%)	267 (-1%)
proof_construction_time_poseidon_hash_100_ms	5,651	1,542 (+2%)	675	715 (-2%)	743 (-1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,356	7,876	14,884
l1_rollup_calldata_gas	50,184	92,998	177,952
l1_rollup_execution_gas	843,025	1,576,735	3,361,745
l2_block_processing_time_in_ms	255	443	823 (+1%)
l2_block_building_time_in_ms	11,200	22,208 (+1%)	43,640 (-1%)
l2_block_rollup_simulation_time_in_ms	11,200	22,208 (+1%)	43,640 (-1%)
l2_block_public_tx_process_time_in_ms	9,563	20,527 (+1%)	41,922 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	2,961	3,901
node_database_size_in_bytes	12,615,760	16,707,664
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	73.8	387 (+2%)	21,391	44,898	N/A
private-kernel-inner	158 (-1%)	683 (+1%)	72,372	45,020	N/A
private-kernel-reset-tiny	297	686 (-1%)	65,097	44,886	N/A
private-kernel-tail	159	133 (-1%)	50,608	52,921	N/A
base-parity	5.53	N/A	160	96.0	N/A
root-parity	35.5 (+1%)	N/A	73,948	96.0	N/A
base-rollup	3,057 (-2%)	N/A	189,193	664	N/A
block-root-rollup	41.5 (+1%)	N/A	58,205	2,448	N/A
public-kernel-setup	80.9 (-1%)	N/A	105,085	71,222	N/A
public-kernel-app-logic	94.0	N/A	104,899	71,222	N/A
public-kernel-tail	846 (+1%)	N/A	390,582	16,414	N/A
private-kernel-reset-small	292 (-1%)	N/A	66,341	45,629	N/A
private-kernel-tail-to-public	767	588 (-1%)	453,751	1,825	N/A
public-kernel-teardown	80.3 (-1%)	N/A	105,349	71,222	N/A
merge-rollup	20.3 (+1%)	N/A	38,174	664	N/A
undefined	N/A	N/A	N/A	N/A	83,132 (-1%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	343
ContractInstanceDeployer:deploy	1,408	11,731	18.2 (+1%)
MultiCallEntrypoint:entrypoint	1,920	11,731	400
FeeJuice:deploy	1,376	11,731	386
SchnorrAccount:constructor	1,312	11,731	62.4
SchnorrAccount:entrypoint	2,336	11,731	369
FeeJuice:claim	1,344	11,731	34.8 (-3%)
Token:privately_mint_private_note	1,280	11,731	75.9
FPC:fee_entrypoint_public	1,344	11,731	25.8 (+7%)
Token:transfer	1,312	11,731	213
Benchmarking:create_note	1,344	11,731	75.8 (+2%)
SchnorrAccount:verify_private_authwit	1,280	11,731	26.6
Token:unshield	1,376	11,731	505 (+1%)
FPC:fee_entrypoint_private	1,376	11,731	662 (-5%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	45.4	2,431
FeeJuice:set_portal	12.5 (-4%)	2,930
Token:constructor	76.8 (+3%)	15,813
FPC:constructor	46.9 (-5%)	9,720
FeeJuice:check_balance	36.3	2,357
Token:mint_public	49.1	5,011
Token:assert_minter_and_mint	466 (-1%)	3,155
AuthRegistry:set_authorized	45.0 (-3%)	924
FPC:prepare_fee	69.9 (-8%)	4,245
Token:transfer_public	⚠️ 36.6 (+74%)	10,812
FPC:pay_refund	48.0 (+11%)	5,195
Benchmarking:increment_balance	1,210 (+1%)	3,496
Token:_increase_public_balance	39.1 (-2%)	2,408
FPC:pay_refund_with_shielded_rebate	50.3	5,195

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.152 (-2%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.16	3.97 (+3%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.112	0.112 (+4%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.1 (+1%)	17.7	31.9 (+2%)	58.5 (-1%)	113 (-1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.106 (+1%)	0.103	0.103 (+2%)	0.101	0.101 (-1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.0 (-2%)	25.4 (-2%)	43.2 (-3%)	82.3 (+1%)	161 (-2%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	108	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.107 (-3%)	0.102 (-2%)	0.105 (-2%)	0.102	0.101 (-4%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.4	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.105	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,838	668,997

Transaction size based on fee payment method

| Metric | |
| - | |

[sklppy88]

Should we use amount, or another name like int ?

[nventuro]

I'd use value here I think. And the type should be called UintNote, not Int.

[sklppy88]

Thanks for the advice. Done.

[nventuro]

Some comment as before re. this trait not being required.

[sklppy88]

As I realized I won't need it anymore, I removed OwnedNote from this implementation and in ValueNote

[nventuro]

I'd use value here I think. And the type should be called UintNote, not Int.