Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove WASMTIME_ENV_HACK #837

Closed
ludamad opened this issue Jan 25, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#4714
Closed

Remove WASMTIME_ENV_HACK #837

ludamad opened this issue Jan 25, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#4714

Comments

@ludamad
Copy link
Collaborator

ludamad commented Jan 25, 2024 •
edited
Loading

This is a kludge because we don't have a proper wasi environment. An obvious improvement, if not reading the real SRS, is to be on curve so proofs can be verified. However, we are only using wasmtime for benchmarking currently, and this helps achieve that. If we want to run wasmtime tests with real SRS we will need to improve this.

Also ideally:

  • get back on mainline google benchmark
  • remove the hardcoded 16 core count in env_hardware_concurrency
@ludamad ludamad mentioned this issue Jan 25, 2024
Merged
ludamad added a commit to AztecProtocol/aztec-packages that referenced this issue Jan 30, 2024
@ludamad @ludamad0
feat(bb): wasmtime and remote benchmarking (#4204)
fd27808 
- provides a script that runs threaded goblin_bench in WASM with 16
cores
- point to https://github.com/AztecProtocol/google-benchmark with
changes for our custom WASI environment. This included removing CMake's
thread library heuristics (which were unneeded, anyway) and adding
checks for a wasm environment when measuring time. See
AztecProtocol/barretenberg#837 for followups.
- remove conditional BENCHMARKS in CMakeLists.txt. There's no reason to
conditionally provide benchmark targets now that WASM can process the
google benchmark cmake
- add some WASMTIME_ENV_HACK guards around fake SRS and a fixed core
count.
- helpers for running benchmarks on remote nodes

---------

Co-authored-by: ludamad <adam@aztecprotocol.com>
AztecBot pushed a commit that referenced this issue Jan 31, 2024
@ludamad @ludamad0 @AztecBot
feat(bb): wasmtime and remote benchmarking (#4204)
b6c030a 
- provides a script that runs threaded goblin_bench in WASM with 16
cores
- point to https://github.com/AztecProtocol/google-benchmark with
changes for our custom WASI environment. This included removing CMake's
thread library heuristics (which were unneeded, anyway) and adding
checks for a wasm environment when measuring time. See
#837 for followups.
- remove conditional BENCHMARKS in CMakeLists.txt. There's no reason to
conditionally provide benchmark targets now that WASM can process the
google benchmark cmake
- add some WASMTIME_ENV_HACK guards around fake SRS and a fixed core
count.
- helpers for running benchmarks on remote nodes

---------

Co-authored-by: ludamad <adam@aztecprotocol.com>
@ludamad ludamad mentioned this issue Feb 22, 2024
Merged
ludamad added a commit to AztecProtocol/aztec-packages that referenced this issue Feb 22, 2024
@ludamad
refactor: remove WASMTIME_ENV_HACK
8040bb1 
Closes AztecProtocol/barretenberg#837
ludamad added a commit to AztecProtocol/aztec-packages that referenced this issue Feb 23, 2024
@ludamad @ludamad0
refactor: remove WASMTIME_ENV_HACK (#4714)
50f89f1 
Closes AztecProtocol/barretenberg#837

Co-authored-by: ludamad <adam@aztecprotocol.com>
AztecBot pushed a commit that referenced this issue Feb 24, 2024
@ludamad @ludamad0 @AztecBot
refactor: remove WASMTIME_ENV_HACK (#4714)
b6af2ab 
Closes #837

Co-authored-by: ludamad <adam@aztecprotocol.com>
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
@ludamad @ludamad0
feat(bb): wasmtime and remote benchmarking (AztecProtocol#4204)
6e200bd 
- provides a script that runs threaded goblin_bench in WASM with 16
cores
- point to https://github.com/AztecProtocol/google-benchmark with
changes for our custom WASI environment. This included removing CMake's
thread library heuristics (which were unneeded, anyway) and adding
checks for a wasm environment when measuring time. See
AztecProtocol/barretenberg#837 for followups.
- remove conditional BENCHMARKS in CMakeLists.txt. There's no reason to
conditionally provide benchmark targets now that WASM can process the
google benchmark cmake
- add some WASMTIME_ENV_HACK guards around fake SRS and a fixed core
count.
- helpers for running benchmarks on remote nodes

---------

Co-authored-by: ludamad <adam@aztecprotocol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove WASMTIME_ENV_HACK AztecProtocol/aztec-packages
1 participant
@ludamad