Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Bug-4714-Admin] Borders for contrast mode and fixed resizing issue for 1280p #1044

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

Rohini-Microsoft
Copy link
Contributor

@Rohini-Microsoft Rohini-Microsoft commented Jun 13, 2024

Purpose

1. High contrast modes
Open CWYD Admin URL.
Go to system setting ->Accessibility->Contrast themes->select aquatic in drop down-> apply.
Go to CWYD Admin URL, you can find the screen, does not have separation border between left collapse and main screen.
Expected result: By providing borders to the fields.

2. Resizing: Text in the page should be adaptable to resizing up to 200% zoom in 1280p without overlap.
Open CWYD Admin URL.
Go to system setting ->System->Display resolution->select 1280P in drop down-> apply.
Go to CWYD Admin URL, you can find the screen, the content is not adaptable.
Expected result: Resize of the content so that the adaptable in the above resolution.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

1. High contrast modes
Open CWYD Admin URL.
Go to system setting ->Accessibility->Contrast themes->select aquatic in drop down-> apply.
Go to CWYD Admin URL, you can find the screen, does not have separation border between left collapse and main screen.

2. Resizing: Text in the page should be adaptable to resizing up to 200% zoom in 1280p without overlap.
Open CWYD Admin URL.
Go to system setting ->System->Display resolution->select 1280P in drop down-> apply.
Go to CWYD Admin URL, you can find the screen, the content is not adaptable.

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Please find attached screenshot

image

image

image

Copy link

github-actions bot commented Jun 13, 2024

Coverage

Coverage Report •
FileStmtsMissCoverMissing
code/backend
   Admin.py23230%5–9, 11, 13–14, 17, 20–21, 23–24, 27, 34–36, 39, 42–44, 46, 48
TOTAL256956578% 

Tests Skipped Failures Errors Time
288 0 💤 0 ❌ 0 🔥 40.002s ⏱️

@Rohini-Microsoft Rohini-Microsoft changed the title fix: Borders for contrast mode and fixed resizing issue for 1280p fix: [Bug-4714-Admin] Borders for contrast mode and fixed resizing issue for 1280p Jun 14, 2024
code/backend/Admin.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Roopan-Microsoft Roopan-Microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the changes

@Roopan-Microsoft Roopan-Microsoft added this pull request to the merge queue Jun 18, 2024
Merged via the queue into main with commit f75e37e Jun 18, 2024
10 checks passed
@Roopan-Microsoft Roopan-Microsoft deleted the PSL-BUG-4714 branch June 18, 2024 10:29
Copy link

🎉 This PR is included in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants