Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh Bicep template #19

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Refresh Bicep template #19

merged 2 commits into from
Jun 7, 2024

Conversation

FBoucher
Copy link
Contributor

Refresh Bicep template coming from AZD source
Fixing potential bugs

github-advanced-security[bot]
github-advanced-security bot found potential problems May 30, 2024
View reviewed changes
infra/core/host/aks-managed-cluster.bicep
@@ -62,7 +62,7 @@
@description('The DNS prefix to associate with the AKS cluster')
param dnsPrefix string = ''

resource aks 'Microsoft.ContainerService/managedClusters@2023-03-02-preview' = {
resource aks 'Microsoft.ContainerService/managedClusters@2023-10-02-preview' = {

Check failure

Code scanning / templateanalyzer

AKS clusters should collect security-based audit logs.

To capture security-based audit logs from AKS clusters, the following diagnostic log categories should be enabled: - kube-audit or kube-audit-admin, or both. - kube-audit - Contains all audit log data for every audit event, including get, list, create, update, delete, patch, and post. - kube-audit-admin - Is a subset of the kube-audit log category. kube-audit-admin reduces the number of logs significantly by excluding the get and list audit events from the log. - guard - Contains logs for Azure Active Directory (AAD) authorization integration. For managed Azure AD, this includes token in and user info out. For Azure RBAC, this includes access reviews in and out.
@tonybaloney
Copy link
Contributor

Please rebase this PR

@FBoucher FBoucher marked this pull request as ready for review June 6, 2024 14:39
@tonybaloney tonybaloney merged commit dd7831a into Azure-Samples:main Jun 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonybaloney tonybaloney tonybaloney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FBoucher @tonybaloney