Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full CSI Driver control #457

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Full CSI Driver control #457

merged 2 commits into from
Nov 14, 2022

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented Nov 12, 2022 •
edited
Loading

PR Summary

Adds 2 settings to control File/Blob CSI drivers.
These are defaulted to true, to maintain current cluster behaviour.

Closes #442

UI

image

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

csi driver changes
68ebe50 
Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby added the enhancement New feature or request label Nov 12, 2022
@Gordonby Gordonby self-assigned this Nov 12, 2022
@Gordonby Gordonby temporarily deployed to csu November 12, 2022 17:58 Inactive
@Gordonby Gordonby enabled auto-merge (squash) November 14, 2022 07:55
samaea
samaea approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@samaea samaea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Gordonby Gordonby merged commit 7673fc6 into main Nov 14, 2022
@Gordonby Gordonby deleted the gb-csistorage branch November 14, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samaea samaea samaea approved these changes

Assignees

@Gordonby Gordonby

Labels
enhancement New feature or request helper-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow opt out of CSI azuredisk and azurefile pods
2 participants
@Gordonby @samaea