Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to assign node public IP to user node pool #464

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

liammoat
Copy link
Contributor

@liammoat liammoat commented Nov 17, 2022

PR Summary

This PR introduces the ability to set enableNodePublicIP. I have opted to enable this only on the user node pool and therefore is not visible when only deploying system node pool.

image

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

@liammoat liammoat linked an issue Nov 17, 2022 that may be closed by this pull request
Copy link
Collaborator

@Gordonby Gordonby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Gordonby Gordonby enabled auto-merge (squash) November 17, 2022 16:18
@Gordonby Gordonby merged commit d5f2534 into main Nov 17, 2022
@Gordonby Gordonby deleted the lm-enablenodepubliciap branch November 17, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for enableNodePublicIP
2 participants