Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodepool name - limit to 12 characters #465

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Nodepool name - limit to 12 characters #465

merged 1 commit into from
Nov 17, 2022

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented Nov 17, 2022

PR Summary

Need to drop the limit from 20 to 12, to stop invalid nodepoolnames being used.

For Linux node pools, the length must be between 1 and 12 characters. For Windows node pools, the length must be between 1 and 6 characters. https://learn.microsoft.com/en-us/azure/aks/use-system-pools?tabs=azure-cli#limitations

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress

Signed-off-by: Gordonby <gordon.byers@microsoft.com>
@Gordonby Gordonby added bug Something isn't working helper-ui 🧙‍♀️ An issue with the UI in the helper labels Nov 17, 2022
@Gordonby Gordonby enabled auto-merge (squash) November 17, 2022 16:42
@Gordonby Gordonby self-assigned this Nov 17, 2022
@Gordonby Gordonby merged commit 51c63ab into main Nov 17, 2022
@Gordonby Gordonby deleted the gb-nodepoollength branch November 17, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working helper-ui 🧙‍♀️ An issue with the UI in the helper helper-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants