-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding PowerShell Deployment Option to the Helper #528
Conversation
Need to check with the team on any functionality that might have been missed |
@Gordonby It has logic to disable the PowerShell tab if the postdeploy.ps1 isn't in the release. So need a release to test it out. |
PR smells stale, no activity for 30 days. Stale Label will be removed if the PR is updated, otherwise closed in a month. |
Mark, I've setup a review meeting to discuss, things I want to check is to ensure it works with private clusters, and local testing. And to ensure we have some test coverage in the actions. |
I'm getting an error when running this command az deployment group create -g gordons --template-file ./bicep/main.bicep --parameters `
resourceName=az-k8s-krcu `
SystemPoolType=Standard `
availabilityZones='["1","2\",\"3"]'
"error": {
"code": "InvalidAvailabilityZoneFormat",
"target": "agentPoolProfile.availabilityZone",
"message": "The specified Availability Zones [1 2\",\"3] are invalid and should be in numeric format."
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
PR Summary
Added deployment option for PowerShell. Decided to to NOT change the az cli commands to PowerShell and only really change the postdeploy.sh script to postdeploy.ps1. I needed to change syntax in the helper and the release action to add in the new script, plus logic the handle old releases where the postdeplo.ps1 isn't available.
PR Checklist