Fixing inline code snippets so that they show up in dark theme #660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Adding in a grey background colour to the code element so that regardless of whether the user is in light or dark theme there is a contrast in the text colour to the background so that it is visible in both themes.
Below are the screenshots of the fixed UI.
Screenshot below is how it used to appear in dark theme. The ".github/workflows" is clearly not visible in dark theme.
In the light theme the code snippets will now have a grey background surrounding the text. In my opinion this is good as most code snippets on the web use a background colour to differentiate the snippet from the rest of the text. Screenshot below is the original light theme without the changes of this PR. It is difficult to tell that the code snippet is different to any of the other surrounding text.
Link to the original issue: #629
PR Checklist