Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest API versions in all modules #245

Closed
wants to merge 1 commit into from

Conversation

olljanat
Copy link
Contributor

Overview/Summary

I found multiple issues especially with WhatIf mode which looks to be happening just because old API versions are used so I decided to switch all modules to use latest APIs listed on https://docs.microsoft.com/en-us/azure/templates/

This PR fixes/adds/changes/removes

One example of this kind of case Azure/bicep#5581 (comment)

Breaking Changes

N/A

Testing Evidence

Should be as long as e2e tests pass.

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • (ALZ Bicep Core Team Only) Associated it with relevant ADO Items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated tests (if required) Unit - Linting - E2E (End-To-End)
  • Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)
  • If relevant, created or updated Code Tours here

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label May 25, 2022
@jtracey93
Copy link
Collaborator

Thanks for raising this and the work here @olljanat im going to close this PR and have opened issue #247 to track this.

This is due to the fact that PR #227 is going to make a lot of changes and this PR would cause merge conflicts no matter which way/order we merge them in.

So, we will pick this up again when #227 is merged and you are of course welcome to pick this up again when that is the case, if you want to?

We hope to get #227 merged in a week or so 👍

cc: @rjygraham

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Needs triaging by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants