fix: certificateRefresher ticker.C timeout #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test comment. |
troy0820
added
priority-medium
|
/azp run ci |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
m1kola
approved these changes
Jul 27, 2021
m1kola
added
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
None
What this PR does / why we need it:
Fixes flaky certRefresher error when running test in a CI.
Issue was hidden in the time.Ticker. When counting number of access to the keyvault, the event occured exactly on the edge of the timeout. Thus it once happened, next time it did not.
Fixed by moving the event closer to the middle of the interval.
Test plan for issue:
N/A
Is there any documentation that needs to be updated for this PR?
N/A