Update client retry delay when calling out to applens endpoint #2780
Conversation
cloudfit-nick
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
facchettos,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan and
ellis-johnson
as code owners
All RP frontend apis have 60s budget before ARM times out |
| MaxRetries: 3, | ||
| RetryDelay: time.Second * 10, | ||
| RetryDelay: time.Second * 3, |
There was a problem hiding this comment.
3 retries times 10 seconds.. that's 30 seconds. What's the timeout per try?
There was a problem hiding this comment.
It has an exponential back off, with a setting of 3 seconds it was erroring out in ~30 seconds (3 seconds + 12 seconds + round trip / response time from all 3 calls). With a setting of 4 seconds, it was erroring out around 50 seconds.
To be safe I went with a setting of 3 seconds.
There was a problem hiding this comment.
That makes sense, but isn't immediately obvious. Can we add some code comments here as breadcrumbs for the next person that comes across this particular setting?
There was a problem hiding this comment.
Note on the place where it defined the setting it already calls out that its exponential.
|
This updates the retry delay from 10 seconds to 3 seconds to ensure that all their calls if needed happen with in 60 seconds.
ARO-2567