Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimal refreshing for SP checks #2901

Merged
merged 1 commit into from
May 9, 2023
Merged

Minimal refreshing for SP checks #2901

merged 1 commit into from
May 9, 2023

Conversation

hawkowl
Copy link
Collaborator

@hawkowl hawkowl commented May 9, 2023

#2896 but smaller

@bennerv
Copy link
Collaborator

bennerv commented May 9, 2023 •
edited
Loading

e2e is green in azure-pipelines, even though it says it is still queued

s-amann
s-amann approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@s-amann s-amann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favor of the smaller set of changes without the refactor. and leaving the refactor for later

@bennerv bennerv merged commit 3520f04 into Azure:master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennerv bennerv bennerv approved these changes

@s-amann s-amann s-amann approved these changes

@jewzaam jewzaam Awaiting requested review from jewzaam jewzaam is a code owner

@rogbas rogbas Awaiting requested review from rogbas rogbas is a code owner

@petrkotas petrkotas Awaiting requested review from petrkotas petrkotas is a code owner

@jharrington22 jharrington22 Awaiting requested review from jharrington22 jharrington22 is a code owner

@cblecker cblecker Awaiting requested review from cblecker cblecker is a code owner

@facchettos facchettos Awaiting requested review from facchettos

@cadenmarchese cadenmarchese Awaiting requested review from cadenmarchese cadenmarchese is a code owner

@UlrichSchlueter UlrichSchlueter Awaiting requested review from UlrichSchlueter UlrichSchlueter is a code owner

@SudoBrendan SudoBrendan Awaiting requested review from SudoBrendan SudoBrendan is a code owner

@ellis-johnson ellis-johnson Awaiting requested review from ellis-johnson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hawkowl @bennerv @s-amann