-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: modify benchmarking workflow and publish build performance artifact #4354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachary-bailey
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
ShiqianTao,
AbelHu,
junjiezhang1997 and
jason1028kr
as code owners
April 26, 2024 17:02
zachary-bailey
changed the title
Zacharybailey/json benchmark artifacts
test: add json benchmark artifacts
Apr 26, 2024
zachary-bailey
changed the title
test: add json benchmark artifacts
test: modify benchmarking workflow and publish build performance artifact
Apr 26, 2024
Pull Request Test Coverage Report for Build 8941515521Details
💛 - Coveralls |
zachary-bailey
force-pushed
the
zacharybailey/jsonBenchmarkArtifacts
branch
from
April 26, 2024 19:32
4c14e02
to
3eb42e1
Compare
zachary-bailey
force-pushed
the
zacharybailey/jsonBenchmarkArtifacts
branch
from
April 29, 2024 17:25
3eb42e1
to
07699d2
Compare
zachary-bailey
force-pushed
the
zacharybailey/jsonBenchmarkArtifacts
branch
from
April 29, 2024 21:43
07699d2
to
ef67046
Compare
zachary-bailey
force-pushed
the
zacharybailey/jsonBenchmarkArtifacts
branch
from
April 30, 2024 22:35
ef67046
to
2eb8751
Compare
zachary-bailey
force-pushed
the
zacharybailey/jsonBenchmarkArtifacts
branch
from
May 1, 2024 19:33
59446d8
to
ce31c17
Compare
zachary-bailey
force-pushed
the
zacharybailey/jsonBenchmarkArtifacts
branch
from
May 2, 2024 14:18
ce31c17
to
1903333
Compare
zachary-bailey
force-pushed
the
zacharybailey/jsonBenchmarkArtifacts
branch
from
May 2, 2024 22:30
1903333
to
fe360d9
Compare
zachary-bailey
force-pushed
the
zacharybailey/jsonBenchmarkArtifacts
branch
from
May 3, 2024 14:30
fe360d9
to
03357f6
Compare
closing PR, new PR will be created |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/test
What this PR does / why we need it:
In addition to publishing a pipeline artifact that contains build performance data, this PR changes the workflow for benchmarking the build process. Changes include removing the
start_watch
function, adding theinstallJq
function, and outputting benchmarking data in JSON instead of formatted strings. At the end of each script, a JSON object will be output in the terminal with performance data for each section.The
installJq
function was necessary because jq is not installed until theinstallDeps
function is called in install-dependencies.sh, but it is needed when the build process starts in pre-install-dependencies.sh.The pipeline artifact that will be published is a JSON file that will contain benchmarking data for the build process. In later changes, github actions will be used to evaluate this artifact and check for build time regression.
The formatting of the artifact can be checked by going to the PR gate build and checking the artifacts list.
Which issue(s) this PR fixes:
This will prevent vhd build times from incrementally increasing due to code changes.
Note: When reviewing "Files changed", please collapse /pkg/agent/testdata to see all relevant file changes
Requirements: