Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: modify benchmarking workflow and publish build performance artifact #4354

Closed
wants to merge 10 commits into from

Conversation

zachary-bailey
Copy link
Collaborator

@zachary-bailey zachary-bailey commented Apr 26, 2024

What type of PR is this?

/test

What this PR does / why we need it:

In addition to publishing a pipeline artifact that contains build performance data, this PR changes the workflow for benchmarking the build process. Changes include removing the start_watch function, adding the installJq function, and outputting benchmarking data in JSON instead of formatted strings. At the end of each script, a JSON object will be output in the terminal with performance data for each section.

The installJq function was necessary because jq is not installed until the installDeps function is called in install-dependencies.sh, but it is needed when the build process starts in pre-install-dependencies.sh.

The pipeline artifact that will be published is a JSON file that will contain benchmarking data for the build process. In later changes, github actions will be used to evaluate this artifact and check for build time regression.

The formatting of the artifact can be checked by going to the PR gate build and checking the artifacts list.

Which issue(s) this PR fixes:

This will prevent vhd build times from incrementally increasing due to code changes.

Note: When reviewing "Files changed", please collapse /pkg/agent/testdata to see all relevant file changes

Requirements:

@zachary-bailey zachary-bailey self-assigned this Apr 26, 2024
@zachary-bailey zachary-bailey changed the title Zacharybailey/json benchmark artifacts test: add json benchmark artifacts Apr 26, 2024
@zachary-bailey zachary-bailey changed the title test: add json benchmark artifacts test: modify benchmarking workflow and publish build performance artifact Apr 26, 2024
@coveralls
Copy link

coveralls commented Apr 26, 2024

Pull Request Test Coverage Report for Build 8941515521

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.258%

Totals Coverage Status
Change from base Build 8931627929: 0.0%
Covered Lines: 3000
Relevant Lines: 3934

💛 - Coveralls

@zachary-bailey
Copy link
Collaborator Author

closing PR, new PR will be created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants