add secondary NSG detection by subnet #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some NSG's are only attached by subnet and not NIC.
add secondary check for NSG by subnet in fucntion NSGCreation()
example output:
2023-01-25T15:13:17-05 [Information] - [NSGCreation] Initiating NSG Creation
2023-01-25T15:13:17-05 [Information] - [NSGCreation] Looping all VMSS in the backend pool of the Load Balancer
2023-01-25T15:13:18-05 [Information] - [NSGCreation] Checking if VMSS Named: nt0 has a NSG
2023-01-25T15:13:20-05 [Warning] - [NSGCreation] NSG detected in Subnet for VMSS Named: nt0 Subnet.NetworkSecurityGroup Id: /subscriptions/.../resourceGroups/.../providers/Microsoft.Network/networkSecurityGroups/VNet-Subnet-0-nsg-eastus
2023-01-25T15:13:20-05 [Warning] - [NSGCreation] NSG will not be created for VMSS Named: nt0
2023-01-25T15:13:20-05 [Information] - [NSGCreation] NSG Creation Completed