Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASimFileEventMicrosoftWindowsEvents.yaml-28 #10594

Merged
merged 42 commits into from
Jul 30, 2024
Merged

ASimFileEventMicrosoftWindowsEvents.yaml-28 #10594

merged 42 commits into from
Jul 30, 2024

Conversation

Alekhya0824
Copy link
Contributor

Required items, please complete

Change(s):

  • Created a new file for SecurityEvents and added SecurityEvents parser in it. In WindowsEvent file removed SecurityEvents parser and in ASimFileEvent added SecurityEvents Parser name and same changes have done for vim as well.

Reason for Change(s):

  • To Split the SecurityEvents and WindowsEvent parser separately

Version Updated:

  • yes

Testing Completed:

  • yes

Checked that the validations are passing and have addressed any issues that are present:

  • yes

@Alekhya0824 Alekhya0824 requested review from a team as code owners June 5, 2024 11:38
@contentautomationbot ContentAutomationBot
Copy link

ASIM parsers have been changed. ARM templates were regenerated from the updated KQL function YAML files.
To find the new ARM templates, pull your branch.

@Alekhya0824 Alekhya0824 changed the title ASimFileEventMicrosoftWindowsEvents.yaml ASimFileEventMicrosoftWindowsEvents.yaml-28 Jun 12, 2024
vakohl
vakohl requested changes Jul 12, 2024
View reviewed changes
Parsers/ASimFileEvent/Parsers/ASimFileEventMicrosoftSecurityEvent.yaml Outdated Show resolved Hide resolved
Parsers/ASimFileEvent/test/Microsoft_Security_Event_ASimFileEvent_SchemaTest.csv Outdated Show resolved Hide resolved
Parsers/ASimFileEvent/test/Microsoft_Security_Events_vimFileEvent_SchemaTest.csv Outdated Show resolved Hide resolved
Parsers/ASimFileEvent/test/Microsoft_Windows_Events_ASimFileEvent_SchemaTest.csv Outdated Show resolved Hide resolved
Parsers/ASimFileEvent/test/Microsoft_Windows_Events_vimFileEvent_SchemaTest.csv Outdated Show resolved Hide resolved
Parsers/ASimFileEvent/Parsers/ASimFileEventMicrosoftWindowsEvents.yaml Outdated Show resolved Hide resolved
Parsers/ASimFileEvent/Parsers/vimFileEventMicrosoftSecurityEvents.yaml Outdated Show resolved Hide resolved
Parsers/ASimFileEvent/Parsers/vimFileEventMicrosoftWindowsEvents.yaml Outdated Show resolved Hide resolved
Parsers/ASimFileEvent/test/Microsoft_Security_Event_ASimFileEvent_SchemaTest.csv Show resolved Hide resolved
Parsers/ASimFileEvent/test/Microsoft_Security_Event_ASimFileEvent_SchemaTest.csv Show resolved Hide resolved
@v-atulyadav
Copy link
Contributor

Hi @Alekhya0824,
Please see above open comments and act on them. Thanks

@v-atulyadav
Copy link
Contributor

Hi @Alekhya0824,
I can see a few open comments from the reviewer. Please act on them.
image
And also, one suggestion: once you're done with the open comment change, please click on the Resolve Conversation button.

@contentautomationbot ContentAutomationBot
Copy link

ASIM parsers have been changed. ARM templates were regenerated from the updated KQL function YAML files.
To find the new ARM templates, pull your branch.

@contentautomationbot ContentAutomationBot
Copy link

ASIM parsers have been changed. ARM templates were regenerated from the updated KQL function YAML files.
To find the new ARM templates, pull your branch.

@contentautomationbot ContentAutomationBot
Copy link

ASIM parsers have been changed. ARM templates were regenerated from the updated KQL function YAML files.
To find the new ARM templates, pull your branch.

@contentautomationbot ContentAutomationBot
Copy link

ASIM parsers have been changed. ARM templates were regenerated from the updated KQL function YAML files.
To find the new ARM templates, pull your branch.

@contentautomationbot ContentAutomationBot
Copy link

ASIM parsers have been changed. ARM templates were regenerated from the updated KQL function YAML files.
To find the new ARM templates, pull your branch.

@contentautomationbot ContentAutomationBot
Copy link

ASIM parsers have been changed. ARM templates were regenerated from the updated KQL function YAML files.
To find the new ARM templates, pull your branch.

@contentautomationbot ContentAutomationBot
Copy link

ASIM parsers have been changed. ARM templates were regenerated from the updated KQL function YAML files.
To find the new ARM templates, pull your branch.

@contentautomationbot ContentAutomationBot
Copy link

ASIM parsers have been changed. ARM templates were regenerated from the updated KQL function YAML files.
To find the new ARM templates, pull your branch.

@contentautomationbot ContentAutomationBot
Copy link

ASIM parsers have been changed. ARM templates were regenerated from the updated KQL function YAML files.
To find the new ARM templates, pull your branch.

@v-atulyadav v-atulyadav merged commit 24f745d into master Jul 30, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-atulyadav v-atulyadav v-atulyadav approved these changes

@vakohl vakohl vakohl approved these changes

Assignees

@vakohl vakohl

@v-atulyadav v-atulyadav

Labels
ASIM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alekhya0824 @v-atulyadav @vakohl @v-prasadboke